Is there any consequences of replacing our knackered 'direct' one with
a new 'indirect' one?

(a) Direct cylinders are perfectly easy to come by.
(b) Indirect ones can be used anyway.

If there is any possibility of connecting it up to a boiler in the future,
get an indirect one.

Christian.